Fix issue with overly trimmed basenames when formatting test paths #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Nov 9, 2019
| )}`, | ||
| ), | ||
| ); | ||
| return slash(chalk.bold(`${TRIMMING_DOTS}${basename.slice(-maxLength + 3)}`)); |
There was a problem hiding this comment.
While working on my previous PR I've noticed this issue. It basically was caused by the fact that maxLength was bigger than basename.length so a negative starting index has been calculated. We don't need to provide both start + end indexes as we always want to slice "till the end" - calculating just a starting index as a negative one simplifies things.
|
Published as 0.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.