promises can resolve to anything

jestjs · Dec 5, 2020 · 0164a7a · 0164a7a
1 parent fbb8999
commit 0164a7a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/jest-types/src/Global.ts b/packages/jest-types/src/Global.ts
@@ -8,8 +8,8 @@
 import type {CoverageMapData} from 'istanbul-lib-coverage';
 
 export type ValidTestReturnValues = void | undefined;
-type TestReturnValuePromise = Promise<ValidTestReturnValues>;
-type TestReturnValueGenerator = Generator<void, ValidTestReturnValues, void>;
+type TestReturnValuePromise = Promise<unknown>;
+type TestReturnValueGenerator = Generator<void, unknown, void>;
 export type TestReturnValue = ValidTestReturnValues | TestReturnValuePromise;
 
 export type TestContext = Record<string, unknown>;

diff --git a/test-types/top-level-globals.test.ts b/test-types/top-level-globals.test.ts
@@ -70,14 +70,18 @@ expectError(test(timeout, fn));
 
 // wrong return value
 expectError(test(testName, () => 42));
-expectError(test(testName, async () => 42));
 
-// mixing done callback and promise
+// mixing done callback and promise/generator
 expectError(
   test(testName, async done => {
     done();
   }),
 );
+expectError(
+  test(testName, function* (done) {
+    done();
+  }),
+);
 
 expectType<void>(test(testName, fn));
 expectType<void>(test(testName, asyncFn));