Skip to content

Commit

Permalink
chore: Review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Mark1626 committed Nov 15, 2020
1 parent d0077f8 commit 2abf528
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Expand Up @@ -7,6 +7,7 @@
- `[jest-snapshot]`: [**BREAKING**] Make prettier optional for inline snapshots - fall back to string replacement ([#7792](https://github.com/facebook/jest/pull/7792))
- `[jest-repl, jest-runner]` [**BREAKING**] Run transforms over environment ([#8751](https://github.com/facebook/jest/pull/8751))
- `[jest-runner]` [**BREAKING**] Run transforms over `runnner` ([#8823](https://github.com/facebook/jest/pull/8823))
- `[jest-runner]` [**BREAKING**] Run transforms over `testRunnner` ([#8823](https://github.com/facebook/jest/pull/8823))

### Fixes

Expand Down Expand Up @@ -552,7 +553,6 @@
- `[@jest/test-result]` Create method to create empty `TestResult` ([#8867](https://github.com/facebook/jest/pull/8867))
- `[jest-worker]` [**BREAKING**] Return a promise from `end()`, resolving with the information whether workers exited gracefully ([#8206](https://github.com/facebook/jest/pull/8206))
- `[jest-reporters]` Transform file paths into hyperlinks ([#8980](https://github.com/facebook/jest/pull/8980))
- `[jest-runner]` [**BREAKING**] Run transforms over `testRunnner` ([#8823](https://github.com/facebook/jest/pull/8823))

### Fixes

Expand Down
10 changes: 4 additions & 6 deletions e2e/coverage-transform-instrumented/package.json
Expand Up @@ -4,15 +4,13 @@
"transform": {
"\\.(js)$": "<rootDir>/preprocessor.js"
},
"transformIgnorePatterns": [
"jest-jasmine2",
"jest-each",
"jest-circus"
],
"testRegex": "/__tests__/.*\\.(js)$",
"testEnvironment": "node",
"transformIgnorePatterns": [
"/jest-environment-node/"
"jest-circus",
"jest-each",
"jest-environment-node/",
"jest-jasmine2"
],
"moduleFileExtensions": [
"js"
Expand Down
5 changes: 3 additions & 2 deletions e2e/transform/babel-jest-ignored/babel.config.js
Expand Up @@ -8,9 +8,10 @@
module.exports = {
only: [
'blablabla',
/jest-environment-node/,
/jest-jasmine2/,
/jest-circus/,
/jest-each/,
/jest-environment-node/,
/jest-jasmine2/,
/jest-source-map/,
],
};
5 changes: 4 additions & 1 deletion e2e/transform/multiple-transformers/package.json
Expand Up @@ -7,7 +7,10 @@
},
"testEnvironment": "node",
"transformIgnorePatterns": [
"/jest-environment-node/", "jest-jasmine2", "jest-circus"]
"/jest-environment-node/",
"jest-jasmine2",
"jest-circus"
]
},
"dependencies": {
"@babel/core": "^7.0.0",
Expand Down
9 changes: 2 additions & 7 deletions e2e/transform/transform-testrunner/babel.config.js
Expand Up @@ -7,12 +7,7 @@

module.exports = {
presets: [
['@babel/preset-typescript'],
[
'@babel/preset-env',
{
targets: {node: 6},
},
],
['@babel/preset-env', {targets: {node: 'current'}}],
'@babel/preset-typescript',
],
};
10 changes: 6 additions & 4 deletions e2e/transform/transform-testrunner/test-runner.ts
Expand Up @@ -4,17 +4,17 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
import {Config} from '@jest/types';
import {JestEnvironment} from '@jest/environment';
import Runtime from 'jest-runtime';
import {TestResult, createEmptyTestResult} from '@jest/test-result';
import {Config} from '@jest/types';
import Runtime from 'jest-runtime';

export default async function testRunner(
globalConfig: Config.GlobalConfig,
config: Config.ProjectConfig,
environment: JestEnvironment,
runtime: Runtime,
testPath: string
testPath: string,
): Promise<TestResult> {
return {
...createEmptyTestResult(),
Expand All @@ -26,9 +26,11 @@ export default async function testRunner(
duration: 2,
failureMessages: [],
fullName: 'sample test',
location: null,
numPassingAsserts: 1,
status: 'passed',
title: 'sample test',
},
],
} as TestResult;
};
}
1 change: 1 addition & 0 deletions yarn.lock
Expand Up @@ -12126,6 +12126,7 @@ fsevents@~2.1.2:
"@jest/console": ^26.6.2
"@jest/environment": ^26.6.2
"@jest/test-result": ^26.6.2
"@jest/transform": ^26.6.2
"@jest/types": ^26.6.2
"@types/exit": ^0.1.30
"@types/graceful-fs": ^4.1.2
Expand Down

0 comments on commit 2abf528

Please sign in to comment.