fix(expect): add types test and improve types

jestjs · Oct 11, 2021 · 3b3c47c · 3b3c47c
1 parent 3a85065
commit 3b3c47c
Show file tree

Hide file tree

Showing 5 changed files with 577 additions and 185 deletions.
diff --git a/packages/expect/src/__tests__/assertionCounts.test.ts b/packages/expect/src/__tests__/assertionCounts.test.ts
@@ -37,6 +37,7 @@ describe('.hasAssertions()', () => {
 
   it('throws if expected is not undefined', () => {
     jestExpect(() => {
+      // @ts-expect-error
       jestExpect.hasAssertions(2);
     }).toThrowErrorMatchingSnapshot();
   });

diff --git a/packages/expect/src/jestMatchersObject.ts b/packages/expect/src/jestMatchersObject.ts
@@ -98,15 +98,12 @@ export const setMatchers = <State extends MatcherState = MatcherState>(
         }
       }
 
-      expect[key] = (...sample: [unknown, ...Array<unknown>]) =>
-        new CustomMatcher(false, ...sample);
-      if (!expect.not) {
-        throw new Error(
-          '`expect.not` is not defined - please report this bug to https://github.com/facebook/jest',
-        );
-      }
-      expect.not[key] = (...sample: [unknown, ...Array<unknown>]) =>
-        new CustomMatcher(true, ...sample);
+      Object.defineProperty(expect, key, {
+        value: (...sample: Array<unknown>) => new CustomMatcher(false, sample),
+      });
+      Object.defineProperty(expect.not, key, {
+        value: (...sample: Array<unknown>) => new CustomMatcher(true, sample),
+      });
     }
   });