jest-circus expect global respects noJestGlobals config

- still adds the snapshot matchers, so they should still work if one were to directly import expect
jestjs · Dec 15, 2019 · 5915a15 · 5915a15
1 parent 131ac13
commit 5915a15
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapter.ts b/packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapter.ts
@@ -30,6 +30,7 @@ const jestAdapter = async (
     .requireInternalModule(path.resolve(__dirname, './jestExpect.js'))
     .default({
       expand: globalConfig.expand,
+      noJestGlobals: !globalConfig.noJestGlobals && !config.noJestGlobals,
     });
 
   const getPrettier = () =>

diff --git a/packages/jest-circus/src/legacy-code-todo-rewrite/jestExpect.ts b/packages/jest-circus/src/legacy-code-todo-rewrite/jestExpect.ts
@@ -15,8 +15,8 @@ import {
   toThrowErrorMatchingSnapshot,
 } from 'jest-snapshot';
 
-export default (config: {expand: boolean}) => {
-  global.expect = expect;
+export default (config: {expand: boolean; noJestGlobals: boolean}) => {
+  if (!config.noJestGlobals) global.expect = expect;
   expect.setState({
     expand: config.expand,
   });