Skip to content

Commit

Permalink
Remove unused sourcemap
Browse files Browse the repository at this point in the history
  • Loading branch information
ychi committed Apr 9, 2020
1 parent a07e185 commit 59b59a1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 14 deletions.
1 change: 0 additions & 1 deletion packages/jest-console/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
}
},
"dependencies": {
"@jest/source-map": "^25.2.6",
"chalk": "^3.0.0",
"jest-message-util": "^25.2.6",
"jest-types": "^25.2.6",
Expand Down
12 changes: 3 additions & 9 deletions packages/jest-console/src/BufferedConsole.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import assert = require('assert');
import {Console} from 'console';
import {format} from 'util';
import chalk = require('chalk');
import type {SourceMapRegistry} from '@jest/source-map';
import {ErrorWithStack} from 'jest-util';

import type {
Expand All @@ -25,18 +24,16 @@ export default class BufferedConsole extends Console {
private _counters: LogCounters;
private _timers: LogTimers;
private _groupDepth: number;
private _getSourceMaps: () => SourceMapRegistry | null | undefined;

constructor(getSourceMaps: () => SourceMapRegistry | null | undefined) {
constructor() {
const buffer: ConsoleBuffer = [];
super({
write: (message: string) => {
BufferedConsole.write(buffer, 'log', message, null, getSourceMaps());
BufferedConsole.write(buffer, 'log', message, null);

return true;
},
} as NodeJS.WritableStream);
this._getSourceMaps = getSourceMaps;
this._buffer = buffer;
this._counters = {};
this._timers = {};
Expand All @@ -48,8 +45,6 @@ export default class BufferedConsole extends Console {
type: LogType,
message: LogMessage,
level?: number | null,
// TODO: remove in 26
_sourceMaps?: SourceMapRegistry | null
): ConsoleBuffer {
const stackLevel = level != null ? level : 2;
const rawStack =
Expand Down Expand Up @@ -77,8 +72,7 @@ export default class BufferedConsole extends Console {
this._buffer,
type,
' '.repeat(this._groupDepth) + message,
3,
this._getSourceMaps(),
3
);
}

Expand Down
1 change: 0 additions & 1 deletion packages/jest-console/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
},
"references": [
{"path": "../jest-message-util"},
{"path": "../jest-source-map"},
{"path": "../jest-types"},
{"path": "../jest-util"}
]
Expand Down
5 changes: 2 additions & 3 deletions packages/jest-runner/src/runTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,7 @@ async function runTestInternal(
[],
type,
message,
4,
runtime && runtime.getSourceMaps(),
4
),
config,
);
Expand All @@ -139,7 +138,7 @@ async function runTestInternal(
} else if (globalConfig.verbose) {
testConsole = new CustomConsole(consoleOut, consoleOut, consoleFormatter);
} else {
testConsole = new BufferedConsole(() => runtime && runtime.getSourceMaps());
testConsole = new BufferedConsole();
}

const environment = new TestEnvironment(config, {
Expand Down

0 comments on commit 59b59a1

Please sign in to comment.