have a default for collectCoverageFrom

jestjs · Nov 17, 2019 · 5f9e417 · 5f9e417
1 parent 454a68e
commit 5f9e417
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/packages/jest-config/src/Defaults.ts b/packages/jest-config/src/Defaults.ts
@@ -21,7 +21,7 @@ const defaultOptions: Config.DefaultOptions = {
   changedFilesWithAncestor: false,
   clearMocks: false,
   collectCoverage: false,
-  collectCoverageFrom: null,
+  collectCoverageFrom: [],
   coverageDirectory: null,
   coveragePathIgnorePatterns: [NODE_MODULES_REGEXP],
   coverageReporters: ['json', 'text', 'lcov', 'clover'],

diff --git a/packages/jest-runtime/src/index.ts b/packages/jest-runtime/src/index.ts
@@ -178,14 +178,7 @@ class Runtime {
     }
   }
 
-  // TODO: Make this `static shouldInstrument = shouldInstrument;` after https://github.com/facebook/jest/issues/7846
-  static shouldInstrument(
-    filename: Config.Path,
-    options: ShouldInstrumentOptions,
-    config: Config.ProjectConfig,
-  ) {
-    return shouldInstrument(filename, options, config);
-  }
+  static shouldInstrument = shouldInstrument;
 
   static createContext(
     config: Config.ProjectConfig,

diff --git a/packages/jest-types/src/Config.ts b/packages/jest-types/src/Config.ts
@@ -36,7 +36,7 @@ export type DefaultOptions = {
   changedFilesWithAncestor: boolean;
   clearMocks: boolean;
   collectCoverage: boolean;
-  collectCoverageFrom: Array<string> | null | undefined;
+  collectCoverageFrom: Array<string>;
   coverageDirectory: string | null | undefined;
   coveragePathIgnorePatterns: Array<string>;
   coverageReporters: Array<string>;