replaced substr with substring (#12066)

jestjs · Nov 18, 2021 · 7bb400c · 7bb400c
1 parent 0486a3c
commit 7bb400c
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,8 @@
 
 ### Chore & Maintenance
 
+- `[*]` Replaced `substr` method with `substring` ([#12066](https://github.com/facebook/jest/pull/12066))
+
 ### Performance
 
 ## 27.3.1

diff --git a/packages/jest-config/src/utils.ts b/packages/jest-config/src/utils.ts
@@ -65,7 +65,7 @@ export const replaceRootDirInPath = (
 
   return path.resolve(
     rootDir,
-    path.normalize('./' + filePath.substr('<rootDir>'.length)),
+    path.normalize('./' + filePath.substring('<rootDir>'.length)),
   );
 };
 

diff --git a/packages/jest-haste-map/src/lib/fast_path.ts b/packages/jest-haste-map/src/lib/fast_path.ts
@@ -10,7 +10,7 @@ import * as path from 'path';
 // rootDir and filename must be absolute paths (resolved)
 export function relative(rootDir: string, filename: string): string {
   return filename.indexOf(rootDir + path.sep) === 0
-    ? filename.substr(rootDir.length + 1)
+    ? filename.substring(rootDir.length + 1)
     : path.relative(rootDir, filename);
 }
 

diff --git a/packages/jest-haste-map/src/worker.ts b/packages/jest-haste-map/src/worker.ts
@@ -63,7 +63,7 @@ export async function worker(data: WorkerMessage): Promise<WorkerMetadata> {
     } catch (err: any) {
       throw new Error(`Cannot parse ${filePath} as JSON: ${err.message}`);
     }
-  } else if (!blacklist.has(filePath.substr(filePath.lastIndexOf('.')))) {
+  } else if (!blacklist.has(filePath.substring(filePath.lastIndexOf('.')))) {
     // Process a random file that is returned as a MODULE.
     if (hasteImpl) {
       id = hasteImpl.getHasteName(filePath);

diff --git a/packages/jest-snapshot/src/index.ts b/packages/jest-snapshot/src/index.ts
@@ -99,7 +99,7 @@ function stripAddedIndentation(inlineSnapshot: string) {
         return inlineSnapshot;
       }
 
-      lines[i] = lines[i].substr(indentation.length);
+      lines[i] = lines[i].substring(indentation.length);
     }
   }
 

diff --git a/packages/jest-transform/src/ScriptTransformer.ts b/packages/jest-transform/src/ScriptTransformer.ts
@@ -876,9 +876,9 @@ function readCodeCacheFile(cachePath: Config.Path): string | null {
   if (content == null) {
     return null;
   }
-  const code = content.substr(33);
+  const code = content.substring(33);
   const checksum = createHash('md5').update(code).digest('hex');
-  if (checksum === content.substr(0, 32)) {
+  if (checksum === content.substring(0, 32)) {
     return code;
   }
   return null;