Remove recursiveBlacklist option from jest-validate (#10650)

jestjs · Dec 5, 2020 · 8a5c4d5 · 8a5c4d5
1 parent 5e2e8ed
commit 8a5c4d5
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 48 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -53,6 +53,7 @@
 - `[jest-runner]` [**BREAKING**] Migrate to ESM ([#10900](https://github.com/facebook/jest/pull/10900))
 - `[jest-runtime]` [**BREAKING**] Remove deprecated and unnused `getSourceMapInfo` from Runtime ([#9969](https://github.com/facebook/jest/pull/9969))
 - `[jest-util]` No longer checking `enumerable` when adding `process.domain` ([#10862](https://github.com/facebook/jest/pull/10862))
+- `[jest-validate]` [**BREAKING**] Remove `recursiveBlacklist ` option in favor of previously introduced `recursiveDenylist` ([#10650](https://github.com/facebook/jest/pull/10650))
 
 ### Performance
 

diff --git a/packages/jest-config/src/normalize.ts b/packages/jest-config/src/normalize.ts
@@ -553,7 +553,7 @@ export default function normalize(
     comment: DOCUMENTATION_NOTE,
     deprecatedConfig: DEPRECATED_CONFIG,
     exampleConfig: VALID_CONFIG,
-    recursiveBlacklist: [
+    recursiveDenylist: [
       'collectCoverageOnlyFrom',
       // 'coverageThreshold' allows to use 'global' and glob strings on the same
       // level, there's currently no way we can deal with such config

diff --git a/packages/jest-validate/src/__tests__/validate.test.ts b/packages/jest-validate/src/__tests__/validate.test.ts
@@ -100,40 +100,6 @@ test.each([
   },
 );
 
-test('respects recursiveBlacklist', () => {
-  const warn = console.warn;
-  console.warn = jest.fn();
-  const config = {
-    something: {
-      nested: {
-        some_random_key: 'value',
-        some_random_key2: 'value2',
-      },
-    },
-  };
-  const exampleConfig = {
-    something: {
-      nested: {
-        test: true,
-      },
-    },
-  };
-
-  validate(config, {exampleConfig});
-
-  expect(console.warn).toBeCalled();
-
-  console.warn.mockReset();
-
-  validate(config, {
-    exampleConfig,
-    recursiveBlacklist: ['something.nested'],
-  });
-
-  expect(console.warn).not.toBeCalled();
-  console.warn = warn;
-});
-
 test('respects recursiveDenylist', () => {
   const warn = console.warn;
   console.warn = jest.fn();

diff --git a/packages/jest-validate/src/types.ts b/packages/jest-validate/src/types.ts
@@ -34,7 +34,6 @@ export type ValidationOptions = {
   ) => void;
   exampleConfig: Record<string, unknown>;
   recursive?: boolean;
-  recursiveBlacklist?: Array<string>;
   recursiveDenylist?: Array<string>;
   title?: Title;
   unknown?: (

diff --git a/packages/jest-validate/src/validate.ts b/packages/jest-validate/src/validate.ts
@@ -70,11 +70,7 @@ const _validate = (
         options.error(key, config[key], exampleConfig[key], options, path);
       }
     } else if (
-      shouldSkipValidationForPath(
-        path,
-        key,
-        options.recursiveDenylist || options.recursiveBlacklist,
-      )
+      shouldSkipValidationForPath(path, key, options.recursiveDenylist)
     ) {
       // skip validating unknown options inside blacklisted paths
     } else {
@@ -85,12 +81,8 @@ const _validate = (
     if (
       options.recursive &&
       !Array.isArray(exampleConfig[key]) &&
-      (options.recursiveDenylist || options.recursiveBlacklist) &&
-      !shouldSkipValidationForPath(
-        path,
-        key,
-        options.recursiveDenylist || options.recursiveBlacklist,
-      )
+      options.recursiveDenylist &&
+      !shouldSkipValidationForPath(path, key, options.recursiveDenylist)
     ) {
       _validate(config[key], exampleConfig[key], options, [...path, key]);
     }
@@ -112,7 +104,7 @@ const validate = (
   // Preserve default denylist entries even with user-supplied denylist
   const combinedDenylist: Array<string> = [
     ...(defaultConfig.recursiveDenylist || []),
-    ...(options.recursiveDenylist || options.recursiveBlacklist || []),
+    ...(options.recursiveDenylist || []),
   ];
 
   const defaultedOptions: ValidationOptions = Object.assign({