Migrate jest-phabricator to TypeScript (#7965)

CHANGELOG.md

@@ -55,6 +55,7 @@
 - `[jest-resolve-dependencies]`: Migrate to TypeScript ([#7922](https://github.com/facebook/jest/pull/7922))
 - `[expect]`: Migrate to TypeScript ([#7919](https://github.com/facebook/jest/pull/7919))
 - `[jest-circus]`: Migrate to TypeScript ([#7916](https://github.com/facebook/jest/pull/7916))
+- `[jest-phabricator]`: Migrate to TypeScript ([#7965](https://github.com/facebook/jest/pull/7965))
 
 ### Performance
 

packages/jest-phabricator/package.json

@@ -6,6 +6,10 @@
     "url": "https://github.com/facebook/jest.git",
     "directory": "packages/jest-phabricator"
   },
+  "types": "build/index.d.ts",
+  "dependencies": {
+    "@jest/types": "^24.1.0"
+  },
   "engines": {
     "node": ">= 6"
   },

packages/jest-phabricator/src/index.js → packages/jest-phabricator/src/index.ts

@@ -3,20 +3,11 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- * @flow
  */
 
-import type {
-  AggregatedResult,
-  AggregatedResultWithoutCoverage,
-  CoverageMap,
-} from 'types/TestResult';
+import {TestResult} from '@jest/types';
 
-type PhabricatorReport = AggregatedResultWithoutCoverage & {
-  coverageMap?: ?CoverageMap,
-};
-
-function summarize(coverageMap: CoverageMap) {
+function summarize(coverageMap: TestResult.CoverageMap) {
   const summaries = Object.create(null);
 
   coverageMap.files().forEach(file => {
@@ -41,8 +32,9 @@ function summarize(coverageMap: CoverageMap) {
   return summaries;
 }
 
-module.exports = function(results: AggregatedResult): PhabricatorReport {
-  // $FlowFixMe: This should work, but it does not.
+module.exports = function(
+  results: TestResult.AggregatedResult,
+): TestResult.AggregatedResult {
   return {
     ...results,
     coverageMap: results.coverageMap && summarize(results.coverageMap),

packages/jest-phabricator/tsconfig.json

@@ -0,0 +1,12 @@
+{
+  "extends": "../../tsconfig.json",
+  "compilerOptions": {
+    "rootDir": "src",
+    "outDir": "build"
+  },
+  "references": [
+    {
+      "path": "../jest-types"
+    }
+  ]
+}

packages/jest-types/src/TestResult.ts

@@ -52,10 +52,10 @@ export type CoverageSummary = {
 };
 
 export type FileCoverage = {
-  getLineCoverage: () => Object;
+  getLineCoverage: () => {[line: string]: string};
   getUncoveredLines: () => Array<number>;
-  getBranchCoverageByLine: () => Object;
-  toJSON: () => Object;
+  getBranchCoverageByLine: () => {[line: string]: string};
+  toJSON: () => {[line: string]: string};
   merge: (other: Object) => undefined;
   computeSimpleTotals: (property: string) => FileCoverageTotal;
   computeBranchTotals: () => FileCoverageTotal;