interface over type so we can extend

jestjs · Feb 17, 2019 · b8f59c8 · b8f59c8
1 parent 6809772
commit b8f59c8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/babel-jest/src/index.ts b/packages/babel-jest/src/index.ts
@@ -23,10 +23,11 @@ const THIS_FILE = fs.readFileSync(__filename);
 const jestPresetPath = require.resolve('babel-preset-jest');
 const babelIstanbulPlugin = require.resolve('babel-plugin-istanbul');
 
-// Make it non-optional
-type TransformerWithFactory = Transformer & {
+// Narrow down the types
+interface TransformerWithFactory extends Transformer {
+  canInstrument: true;
   createTransformer: (options?: TransformOptions) => TransformerWithFactory;
-};
+}
 
 const createTransformer = (
   options: TransformOptions = {},

diff --git a/packages/jest-transform/src/types.ts b/packages/jest-transform/src/types.ts
@@ -51,7 +51,7 @@ export type CacheKeyOptions = {
   rootDir: string;
 };
 
-export type Transformer = {
+export interface Transformer {
   canInstrument?: boolean;
   createTransformer?: (options?: any) => Transformer;
 
@@ -68,4 +68,4 @@ export type Transformer = {
     config: Config.ProjectConfig,
     options?: TransformOptions,
   ) => string | TransformedSource;
-};
+}