fix: fix any() for symbols, bigints, null (#10179)

jestjs · Jul 2, 2020 · cd23c45 · cd23c45
1 parent 22b8e85
commit cd23c45
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Fixes
 
+- `[expect]` Match symbols and bigints in `any()`; stop matching `null` ([#10223](https://github.com/facebook/jest/pull/10223))
+
 ### Chore & Maintenance
 
 ### Performance

diff --git a/packages/expect/src/__tests__/asymmetricMatchers.test.ts b/packages/expect/src/__tests__/asymmetricMatchers.test.ts
@@ -29,7 +29,11 @@ test('Any.asymmetricMatch()', () => {
     any(Number).asymmetricMatch(1),
     any(Function).asymmetricMatch(() => {}),
     any(Boolean).asymmetricMatch(true),
+    /* global BigInt */
+    any(BigInt).asymmetricMatch(1n),
+    any(Symbol).asymmetricMatch(Symbol()),
     any(Object).asymmetricMatch({}),
+    !any(Object).asymmetricMatch(null),
     any(Array).asymmetricMatch([]),
     any(Thing).asymmetricMatch(new Thing()),
   ].forEach(test => {

diff --git a/packages/expect/src/asymmetricMatchers.ts b/packages/expect/src/asymmetricMatchers.ts
@@ -46,13 +46,22 @@ class Any extends AsymmetricMatcher<any> {
     }
 
     if (this.sample == Object) {
-      return typeof other == 'object';
+      return typeof other == 'object' && other !== null;
     }
 
     if (this.sample == Boolean) {
       return typeof other == 'boolean';
     }
 
+    /* global BigInt */
+    if (this.sample == BigInt) {
+      return typeof other == 'bigint';
+    }
+
+    if (this.sample == Symbol) {
+      return typeof other == 'symbol';
+    }
+
     return other instanceof this.sample;
   }