You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
@SimenB nope, it's a fix for two of three errors that appeared on CI on all PRs. The third one that is still breaking CI is weird and hard to fix and I'm not sure about it. The actual cause for the three new errors was very likely the TS update, but it's very strange that the errors didn't appear on the PR of that update or the merge commit itself, only later. See #13633 (comment)
The reason will be displayed to describe this comment to others. Learn more.
@jeysal Perhaps it would make sense opening a PR downgrade the TS version? Just to see if that’s the problem. I could do a bit later.
The failure is odd indeed. I was looking at it. Feels like it could be caused by some change in GH infrastructure. Because PRs and commits were not failing. Also it does not reproduce locally.
ef91356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeysal seems this broke CI?
ef91356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB nope, it's a fix for two of three errors that appeared on CI on all PRs. The third one that is still breaking CI is weird and hard to fix and I'm not sure about it. The actual cause for the three new errors was very likely the TS update, but it's very strange that the errors didn't appear on the PR of that update or the merge commit itself, only later. See #13633 (comment)
ef91356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeysal Perhaps it would make sense opening a PR downgrade the TS version? Just to see if that’s the problem. I could do a bit later.
The failure is odd indeed. I was looking at it. Feels like it could be caused by some change in GH infrastructure. Because PRs and commits were not failing. Also it does not reproduce locally.