Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated left-pad #8516

Closed
sidoruk-sv opened this issue May 31, 2019 · 4 comments
Closed

Deprecated left-pad #8516

sidoruk-sv opened this issue May 31, 2019 · 4 comments

Comments

@sidoruk-sv
Copy link

sidoruk-sv commented May 31, 2019

馃殌 Feature Proposal

Replace left-pad with String.prototype.padStart() (from deprecation message):
https://www.npmjs.com/package/left-pad

use String.prototype.padStart()

Example

Please provide an example for how this feature would be used.
Need to be done:

Remove left-pad dependency here: https://github.com/facebook/jest/blob/master/package.json#L57

Remove import of left-pad here:
https://github.com/facebook/jest/blob/master/packages/pretty-format/perf/test.js#L13

Replace leftPad(current.time, 6) with String(current.time).padStart(6) here:
https://github.com/facebook/jest/blob/master/packages/pretty-format/perf/test.js#L83

@thymikee
Copy link
Collaborator

Send a PR please? :)

@sidoruk-sv
Copy link
Author

sidoruk-sv commented May 31, 2019

Send a PR please? :)

@thymikee sure, please review #8517

@SimenB
Copy link
Member

SimenB commented Aug 22, 2019

Fixed via #8850 (and #8851 which pulled it in transitively)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants