Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty-format: replace left-pad with String.prototype.padStart() #8517

Closed
wants to merge 1 commit into from
Closed

pretty-format: replace left-pad with String.prototype.padStart() #8517

wants to merge 1 commit into from

Conversation

sidoruk-sv
Copy link

fix #8516

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sidoruk-sv sidoruk-sv mentioned this pull request May 31, 2019
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Did you run Yarn to update the lockfile?
Also note that I think there's also a dependency on left-pad via an outdated jsdom, so until we can update that users will probably still see warnings sometimes

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #8517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8517   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         269      269           
  Lines       11045    11045           
  Branches     2690     2690           
=======================================
  Hits         6689     6689           
  Misses       3770     3770           
  Partials      586      586

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a13e7...2e2e801. Read the comment docs.

@sidoruk-sv
Copy link
Author

@jeysal yarn.lock updated too

@jeysal
Copy link
Contributor

jeysal commented May 31, 2019

Thanks! Should wait for #8455 then we can merge this. (padStart is Node 8+)

@thymikee thymikee added this to the Jest 25 milestone Jun 14, 2019
@SimenB
Copy link
Member

SimenB commented Aug 22, 2019

Oh sorry, I forgot about this PR 😬 I fixed it as part of #8850

@SimenB SimenB closed this Aug 22, 2019
@jeysal jeysal removed this from the Jest 26 milestone Jan 22, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated left-pad
6 participants