Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pretty-format to respect displayName on forwardRef. #10120

Closed
wants to merge 1 commit into from
Closed

Fix pretty-format to respect displayName on forwardRef. #10120

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2020

Amd1090T.pdf
Unlike React DevTools, Jest ignores a custom displayName set on forwardRef components. We should align serialization with DevTools, so change behavior.

Summary

Test plan

@scotthovestadt
Fix pretty-format to respect displayName on forwardRef.
ccf945f 
Unlike React DevTools, Jest ignores a custom displayName set on forwardRef components. We should align serialization with DevTools, so change behavior.
@facebook-github-bot
Copy link
Contributor

Hi @Ismail-proto!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB
SimenB requested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add a test that fails without your change and a changelog entry, please? 🙂

sunlaiman
sunlaiman reviewed Jul 25, 2020
View reviewed changes
Copy link

@sunlaiman sunlaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10120

sunlaiman
sunlaiman approved these changes Jul 25, 2020
View reviewed changes
Copy link

@sunlaiman sunlaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2549

@SimenB SimenB mentioned this pull request Jul 27, 2020
Closed
@SimenB
Copy link
Member

SimenB commented Jul 30, 2020

Seems to me like this is just #9422

@SimenB SimenB closed this Jul 30, 2020
@SimenB SimenB deleted the forwardref-display-name branch July 30, 2020 09:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@facebook-github-bot @SimenB @sunlaiman @scotthovestadt