Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toMatchObject works with super getters #10381

Merged
merged 3 commits into from Aug 22, 2020
Merged

fix: toMatchObject works with super getters #10381

merged 3 commits into from Aug 22, 2020

Commits on Aug 21, 2020

  1. fix(expect): toMatchObject with inherited getters 

    - It also works with `defineProperty`
- There's still a bit of work to be done on
  improving the reporting of this
    @souldzin
    souldzin committed Aug 21, 2020
    Copy the full SHA
    a8e7e67 View commit details
    Browse the repository at this point in the history

  2. Recurse proto chain in hasPropertyInObject 

    This way we can catch the actual props of the object
without catching those in Object.prototype
    @souldzin
    souldzin committed Aug 21, 2020
    Copy the full SHA
    3467338 View commit details
    Browse the repository at this point in the history

  3. Replace hasOwnProperty with hasPropertyInObject

    @souldzin
    souldzin committed Aug 21, 2020
    Copy the full SHA
    1dde15b View commit details
    Browse the repository at this point in the history