Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 9701 #10384

Closed
wants to merge 2 commits into from
Closed

issue 9701 #10384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed0af2d
issue 9701 - timeout is a value in seconds, according to node-notifie…
ildella Aug 9, 2020
96ac468
updated CHANGELOG
ildella Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

- `[jest-leak-detector]` Wait properly for GC runs due to changes in Node 14.7 ([#10366](https://github.com/facebook/jest/pull/10366))
- `[jest-worker]` Downgrade minimum node version to 10.13 ([#10352](https://github.com/facebook/jest/pull/10352))
- `[jest-reporters]` Use correct 'timeout' value to re-activate Notifications as per issue 9701 - ([#10384](https://github.com/facebook/jest/pull/10384))

### Chore & Maintenance

Expand Down
6 changes: 3 additions & 3 deletions packages/jest-reporters/src/notify_reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export default class NotifyReporter extends BaseReporter {
result.numPassedTests,
)} passed`;

this._notifier.notify({icon, message, timeout: false, title});
this._notifier.notify({icon, message, timeout: 5, title});
} else if (
testsHaveRun &&
!success &&
Expand Down Expand Up @@ -107,15 +107,15 @@ export default class NotifyReporter extends BaseReporter {
const quitAnswer = 'Exit tests';

if (!watchMode) {
this._notifier.notify({icon, message, timeout: false, title});
this._notifier.notify({icon, message, timeout: 5, title});
} else {
this._notifier.notify(
{
actions: [restartAnswer, quitAnswer],
closeLabel: 'Close',
icon,
message,
timeout: false,
timeout: 5,
title,
// https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42303
} as any,
Expand Down