Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fail tests when multiple done() calls are made #10624

Merged
merged 22 commits into from Dec 22, 2020
Merged

feat: fail tests when multiple done() calls are made #10624

merged 22 commits into from Dec 22, 2020

Commits on Dec 7, 2020

  1. fix: 'done' should not be called more than once 

    Update CHANGELOG.md

Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

Update packages/jest-circus/src/utils.ts

Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

Apply suggestions from code review

Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

Update packages/jest-circus/src/utils.ts

Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

move logic outside promise

migrate `seenDone` from global state to local

update snapshot

rm `seenDone` reset

Apply suggestions from code review

Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

fix linting

modify errorstack and test snapshot

update snapshot

move seenDone check to after reason

move seenDone check

revert position change

lint

fix test
    @flozender
    flozender committed Dec 7, 2020
    Copy the full SHA
    4612898 View commit details
    Browse the repository at this point in the history

  2. fix import order

    @flozender
    flozender committed Dec 7, 2020
    Copy the full SHA
    b6507c8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/facebook/jest into fail-done

    @flozender
    flozender committed Dec 7, 2020
    Copy the full SHA
    7939e21 View commit details
    Browse the repository at this point in the history

  4. fix snapshot line number

    @flozender
    flozender committed Dec 7, 2020
    Copy the full SHA
    f4253ca View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Update CHANGELOG.md 

    Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
    @flozender @SimenB
    flozender and SimenB committed Dec 8, 2020
    Copy the full SHA
    1b2b07d View commit details
    Browse the repository at this point in the history

  2. replace then with await

    @flozender
    flozender committed Dec 8, 2020
    Copy the full SHA
    300ab59 View commit details
    Browse the repository at this point in the history

  3. move seenDone check after environment teardown check

    @flozender
    flozender committed Dec 8, 2020
    Copy the full SHA
    d507eb1 View commit details
    Browse the repository at this point in the history

  4. add completed to seenDone check

    @flozender
    flozender committed Dec 8, 2020
    Copy the full SHA
    f5e61d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. add reason to message

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    e03d211 View commit details
    Browse the repository at this point in the history

  2. reset seenDone before each test and hook

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    3dd1f5e View commit details
    Browse the repository at this point in the history

  3. reset seenDone before each test and hook

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    9364669 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fail-done' of https://github.com/mlh-fellowship/jest in… 

    …to fail-done
    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    ffacfef View commit details
    Browse the repository at this point in the history

  5. Update packages/jest-circus/src/utils.ts 

    Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
    @flozender @SimenB
    flozender and SimenB committed Dec 9, 2020
    Copy the full SHA
    1b92362 View commit details
    Browse the repository at this point in the history

  6. reuse error, update snapshot, and add seenDone resets

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    113264f View commit details
    Browse the repository at this point in the history

  7. update snapshot

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    66d6092 View commit details
    Browse the repository at this point in the history

  8. test multiple done inside a hook

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    b3929c8 View commit details
    Browse the repository at this point in the history

  9. skip on jasmine

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    92a09b2 View commit details
    Browse the repository at this point in the history

  10. add all hooks

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    b661de8 View commit details
    Browse the repository at this point in the history

  11. add all hooks

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    50938cd View commit details
    Browse the repository at this point in the history

  12. add all hooks

    @flozender
    flozender committed Dec 9, 2020
    Copy the full SHA
    ad7c69e View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Merge branch 'master' into fail-done

    @SimenB
    SimenB committed Dec 22, 2020
    Copy the full SHA
    8f9fcd3 View commit details
    Browse the repository at this point in the history

  2. Update utils.ts

    @SimenB
    SimenB committed Dec 22, 2020
    Copy the full SHA
    7cdb33a View commit details
    Browse the repository at this point in the history