Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): throw correct error for missing preset modules #10737

Merged
merged 5 commits into from Oct 31, 2020

Commits on Oct 30, 2020

  1. fix(jest-config): throw correct error for missing preset modules

    When loading a preset module that cannot be resolved (e.g. is not npm
    installed), the following error is shown to users:
    
        ● Validation Error:
    
          Preset foobar is invalid:
    
          The "id" argument must be of type string. Received null
    
    Instead, the following error should be shown
    
        ● Validation Error:
    
          Preset foobar not found.
    
    This PR changes the error message by handling when
    Resolver.findNodeModule returns null, indicating that the module cannot
    be successfully imported.
    terite committed Oct 30, 2020
    Copy the full SHA
    0c52b10 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    5710cf9 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    ca8c88b View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    7b0d40d View commit details
    Browse the repository at this point in the history
  5. Update CHANGELOG.md

    SimenB committed Oct 30, 2020
    Copy the full SHA
    2012e7e View commit details
    Browse the repository at this point in the history