New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10451 - beforeAll block & tests marked with only & todo runs even if it is inside a describe.skip block #10806
Changes from 4 commits
149a2e3
43fb572
0276ed8
c22c726
a700b0e
b968692
a485155
18715a0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -65,10 +65,11 @@ export default function treeProcessor(options: Options): void { | |||||
} | ||||||
|
||||||
function hasNoEnabledTest(node: TreeNode): boolean { | ||||||
if (node.children) { | ||||||
return node.children.every(hasNoEnabledTest); | ||||||
} | ||||||
return node.disabled || node.markedPending; | ||||||
return ( | ||||||
node.disabled || | ||||||
node.markedPending || | ||||||
(!!node.children && node.children.every(hasNoEnabledTest)) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. Made the change. However since ts is prompting for a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, I have done the changes |
||||||
); | ||||||
} | ||||||
|
||||||
function wrapChildren(node: TreeNode, enabled: boolean) { | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should be under the existent
Fixes
headingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I have made the changes