Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support default exports for runners #10826

Closed
wants to merge 3 commits into from
Closed

Support default exports for runners #10826

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de04fc8
Support default exports for runners
palmerj3 Nov 14, 2020
809137a
Switch Runner to const
palmerj3 Nov 14, 2020
c1c3466
Fix prettier issue in TestScheduler
palmerj3 Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/jest-core/src/TestScheduler.ts
View file
Open in desktop
Expand Up @@ -193,7 +193,8 @@ export default class TestScheduler {
contexts.forEach(context => {
const {config} = context;
if (!testRunners[config.runner]) {
const Runner: typeof TestRunner = require(config.runner);
const Runner: typeof TestRunner =
require(config.runner).default || require(config.runner);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a helper for this: https://github.com/facebook/jest/blob/dbb12903801f7423f0273d4c1872294e9dbbc5ce/packages/jest-util/src/interopRequireDefault.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok cool. Later on I'll try to make use of this and add a changelog entry.

const runner = new Runner(this._globalConfig, {
changedFiles: this._context?.changedFiles,
sourcesRelatedToTestsInChangedFiles: this._context
Expand Down