Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(babel-plugin-jest-hoist): allow using module wrapper arguments in hoisted mock factory function #10903

Merged
merged 3 commits into from Dec 3, 2020
Merged

fix(babel-plugin-jest-hoist): allow using module wrapper arguments in hoisted mock factory function #10903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78414cb
Allow __dirname and __filename in hoisted mock factory function
theneva Dec 2, 2020
16925a5
add all module wrapper fields; order
theneva Dec 2, 2020
fb47852
Update CHANGELOG.md
SimenB Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -12,6 +12,7 @@

### Fixes

- `[babel-plugin-jest-hoist]` Add `__dirname` and `__filename` to whitelisted globals ([#10903](https://github.com/facebook/jest/pull/10903))
- `[expect]` [**BREAKING**] Revise `expect.not.objectContaining()` to be the inverse of `expect.objectContaining()`, as documented. ([#10708](https://github.com/facebook/jest/pull/10708))
- `[jest-circus]` Fixed the issue of beforeAll & afterAll hooks getting executed even if it is inside a skipped `describe` block [#10451](https://github.com/facebook/jest/issues/10451)
- `[jest-circus]` Fix `testLocation` on Windows when using `test.each` ([#10871](https://github.com/facebook/jest/pull/10871))
Expand Down
4 changes: 4 additions & 0 deletions packages/babel-plugin-jest-hoist/src/index.ts
View file
Open in desktop
Expand Up @@ -85,7 +85,11 @@ const ALLOWED_IDENTIFIERS = new Set<string>(
'jest',
'parseFloat',
'parseInt',
'exports',
'require',
'module',
'__filename',
'__dirname',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grouped these with require in the order that the module wrapper passes them

'undefined',
...Object.getOwnPropertyNames(global),
].sort(),
Expand Down