[wip] Fix(jest-core): remove onAction awaits
#10979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauravhiremath
changed the title
onAction awaitsonAction awaits
sauravhiremath
commented
Dec 25, 2020
| @@ -126,7 +137,7 @@ test('schedule tests run in serial if the runner flags them', async () => { | |||
| await scheduler.scheduleTests(tests, {isInterrupted: jest.fn()}); | |||
|
|
|||
| expect(mockSerialRunner.runTests).toHaveBeenCalled(); | |||
| expect(mockSerialRunner.runTests.mock.calls[0][5].serial).toBeTruthy(); | |||
| expect(mockSerialRunner.runTests.mock.calls[0][2].serial).toBeTruthy(); | |||
| }); | |||
|
|
|||
| test('should bail after `n` failures', async () => { | |||
There was a problem hiding this comment.
@SimenB Could you suggest a better implementation for mocking eventEmitters (extended from Emittery)? Need to get the should bail after 'n' failures test passing
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress
Summary
Removes
onStart,onSuccess, etc callbacks and uses eventEmitters as the only source of truth.Refer discussion: #10227 (comment)
Test plan
onActionawaits