Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update fsevents #11028

Merged
merged 2 commits into from
Jan 26, 2021
Merged

chore: update fsevents #11028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd66d9
build: update fsevents to include stability fixes
cmdcarini Jan 25, 2021
1f22eac
Merge branch 'master' into patch/fsevents-2.2.1
SimenB Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jest-haste-map/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"slash": "^3.0.0"
},
"optionalDependencies": {
"fsevents": "^2.1.2"
"fsevents": "^2.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run yarn to update the lockfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should (hopefully) be done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you used Yarn 1 to do that instead of the checked in version, how old is your Yarn 1 version since it didn't pick up on the yarn-path setting?

Copy link
Member

@SimenB SimenB Jan 26, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merceyz I tried to fix it, but the patch in yarn v2 seems broken.

➤ YN0066: │ fsevents@patch:fsevents@npm%3A2.3.1#builtin<compat/fsevents>::version=2.3.1&hash=127e8e: Cannot apply hunk #1
➤ YN0000: │     }
➤ YN0000: │
➤ YN0028: │ -   let instance = Native.start(path, handler);
➤ YN0028: │ +   let VFS = require('./vfs');
➤ YN0028: │ +   let vfs = new VFS(path);
➤ YN0028: │ +   let instance = Native.start(vfs.resolvedPath, vfs.wrap(handler));
➤ YN0000: │     if (!instance) throw new Error(`could not watch: ${path}`);
➤ YN0000: │     return () => {

(same for 2.2.1, fwiw)

Copy link
Contributor

@merceyz merceyz Jan 26, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fixed in yarnpkg/berry#2078 (yarn set version latest)

Copy link
Member

@SimenB SimenB Jan 26, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the fork was super outdated (over 120 commits behind) and had an old version of yarn. Merging in master fixed the issue 👍

},
"engines": {
"node": ">= 10.14.2"
Expand Down