refactor(jest-config): change normalize to async function
#11179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff @ahnpnl! I actually started with this locally, but as you say there were so many changes to the tests I just noped out of it 🙈 |
SimenB
reviewed
Mar 11, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #11167
I would love to include support
presetin ESM changes into one PR but it looks kind of a lot of changes because changing onlynormalizeto async function already took quite some efforts to correct tests. Therefore this PR is to split up those changes.Bonus: Also converted
normalize.test.jstonormalize.test.tsand fixed as many IDE complaints as possible.Test plan
Green CI