Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect open handles with done callbacks #11382

Merged
merged 13 commits into from May 20, 2021
Merged

Detect open handles with done callbacks #11382

merged 13 commits into from May 20, 2021

Commits on May 6, 2021

  1. Add failing tests for open handles with done 

    This adds a unit test and two new integration tests to assert that hanging async handles created in test or lifecycle functions with `done` callbacks are correctly detected and logged when using `--detectOpenHandles`. They all fail when used with the Jasmine runner right now (things work fine with Circus; yay!).
    @Mr0grog
    Mr0grog committed May 6, 2021
    Copy the full SHA
    8c6276d View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Wrap functions w/ a callback in a named function 

    Wrap test and lifecycle functions that take a `done` callback in a named function so that they can be detected as user code in the call stack. This lets the `collectHandles` module in jest-core know to track async resources created in those functions.

Fixes jestjs#11377.
    @Mr0grog
    Mr0grog committed May 7, 2021
    Copy the full SHA
    125d47b View commit details
    Browse the repository at this point in the history

  2. Add missing copyright headers

    @Mr0grog
    Mr0grog committed May 7, 2021
    Copy the full SHA
    799399e View commit details
    Browse the repository at this point in the history

  3. Fix runtime type-checking for non-functions

    @Mr0grog
    Mr0grog committed May 7, 2021
    Copy the full SHA
    6d47be8 View commit details
    Browse the repository at this point in the history

  4. Update snapshot tests with new callstacks

    @Mr0grog
    Mr0grog committed May 7, 2021
    Copy the full SHA
    944f969 View commit details
    Browse the repository at this point in the history

  5. Keep correct this for wrapped test functions

    @Mr0grog
    Mr0grog committed May 7, 2021
    Copy the full SHA
    bdb38fd View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. Update packages/jest-jasmine2/src/jasmineAsyncInstall.ts 

    Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
    @Mr0grog @SimenB
    Mr0grog and SimenB committed May 8, 2021
    Copy the full SHA
    2088443 View commit details
    Browse the repository at this point in the history

  2. Update packages/jest-jasmine2/src/jasmineAsyncInstall.ts 

    Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
    @Mr0grog @SimenB
    Mr0grog and SimenB committed May 8, 2021
    Copy the full SHA
    2adf035 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. Use correct type for this in test functions

    @Mr0grog
    Mr0grog committed May 9, 2021
    Copy the full SHA
    ca185ca View commit details
    Browse the repository at this point in the history

  2. Add changelog entries for jestjs#11382

    @Mr0grog
    Mr0grog committed May 9, 2021
    Copy the full SHA
    439018f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Follow existing test style without --forceExit

    @Mr0grog
    Mr0grog committed May 19, 2021
    Copy the full SHA
    b144f11 View commit details
    Browse the repository at this point in the history

  2. Tweak implementation to pass both Jasmine & Circus

    @Mr0grog
    Mr0grog committed May 19, 2021
    Copy the full SHA
    6eb3969 View commit details
    Browse the repository at this point in the history

  3. Revert to previous implementation and tweak test

    @Mr0grog
    Mr0grog committed May 19, 2021
    Copy the full SHA
    4803a6c View commit details
    Browse the repository at this point in the history