Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct type from process.send stub #11799

Merged
merged 3 commits into from Sep 9, 2021
Merged

Commits on Aug 30, 2021

  1. fix: return correct type from process.send stub

    The `process.send` stub created by Jest always returns `undefined` but Node actually always returns `boolean` value from `process.send` (see types [1](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7f660501fbf2e57f885cabf9723aa57c8bfe4f47/types/node/process.d.ts#L1268-L1275) and [2](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7f660501fbf2e57f885cabf9723aa57c8bfe4f47/types/node/child_process.d.ts#L447-L449), as well as [Node docs](https://nodejs.org/dist/latest-v14.x/docs/api/process.html#process_process_send_message_sendhandle_options_callback))
    
    By default, it returns `true` and only returns `false` when the IPC message is buffered or the child process had already exited, see [related docs on child_process](https://nodejs.org/dist/latest-v14.x/docs/api/child_process.html#child_process_subprocess_send_message_sendhandle_options_callback)
    vladar committed Aug 30, 2021
    Copy the full SHA
    737a670 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Update changelog

    vladar committed Sep 1, 2021
    Copy the full SHA
    5a6d3db View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Copy the full SHA
    d3f9b7b View commit details
    Browse the repository at this point in the history