Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(environment-jsdom): allow passing html content to jsdom environment #11950

Merged
merged 7 commits into from Oct 16, 2021
Merged

feat(environment-jsdom): allow passing html content to jsdom environment #11950

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b9f45b
feat(environment-jsdom): allow passing html content to jsdom environment
MarvelSQ Oct 11, 2021
ae8958b
test(environment-jsdom): add test case
MarvelSQ Oct 12, 2021
65b439b
fix(custom-jsdom-html): fix style & babel config
MarvelSQ Oct 12, 2021
4b30111
docs(custom-jsdom-html): add html to Configuration
MarvelSQ Oct 12, 2021
6103b55
docs(custom-jsdom-html): update CHANGELOG
MarvelSQ Oct 12, 2021
144a9d5
fix(custom-jsdom-html): fix formatting
MarvelSQ Oct 15, 2021
7e7e5b4
fix(custom-jsdom-html): add Copyright Header
MarvelSQ Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
@@ -1,7 +1,7 @@
## main

### Features

SimenB marked this conversation as resolved.
Show resolved Hide resolved
- `[jest-config]` Add `testEnvironmentOptions.html` to apply to jsdom input ([11950](https://github.com/facebook/jest/pull/11950))
### Fixes

- `[jest-runtime]` Ensure absolute paths can be resolved within test modules ([11943](https://github.com/facebook/jest/pull/11943))
Expand Down
2 changes: 1 addition & 1 deletion docs/Configuration.md
View file
Open in desktop
Expand Up @@ -1170,7 +1170,7 @@ beforeAll(() => {

Default: `{}`

Test environment options that will be passed to the `testEnvironment`. The relevant options depend on the environment. For example, you can override options given to [jsdom](https://github.com/jsdom/jsdom) such as `{userAgent: "Agent/007"}`.
Test environment options that will be passed to the `testEnvironment`. The relevant options depend on the environment. For example, you can override options given to [jsdom](https://github.com/jsdom/jsdom) such as `{html: "<html lang="zh-cmn-Hant"></html>", userAgent: "Agent/007"}`.

### `testFailureExitCode` \[number]

Expand Down
4 changes: 4 additions & 0 deletions e2e/custom-jsdom-html/__tests__/test.js
View file
Open in desktop
@@ -0,0 +1,4 @@
test('jsdom custom html', () => {
/* eslint-disable-next-line no-undef */
expect(document.getElementById('root')).toBeTruthy();
});
12 changes: 12 additions & 0 deletions e2e/custom-jsdom-html/babel.config.js
View file
Open in desktop
@@ -0,0 +1,12 @@
module.exports = {
presets: [
[
'@babel/env',
{
targets: {
node: 'current',
},
},
],
],
};
13 changes: 13 additions & 0 deletions e2e/custom-jsdom-html/package.json
View file
Open in desktop
@@ -0,0 +1,13 @@
{
"dependencies": {
"@babel/core": "^7.2.2",
"@babel/preset-env": "^7.2.2"
},
"jest": {
"testEnvironment": "jsdom",
"testEnvironmentOptions": {
"html": "<div id=\"root\"></div>"
}
}
}

SimenB marked this conversation as resolved.
Show resolved Hide resolved
33 changes: 20 additions & 13 deletions packages/jest-environment-jsdom/src/index.ts
View file
Open in desktop
Expand Up @@ -31,19 +31,26 @@ class JSDOMEnvironment implements JestEnvironment<number> {
moduleMocker: ModuleMocker | null;

constructor(config: Config.ProjectConfig, options?: EnvironmentContext) {
this.dom = new JSDOM('<!DOCTYPE html>', {
pretendToBeVisual: true,
resources:
typeof config.testEnvironmentOptions.userAgent === 'string'
? new ResourceLoader({
userAgent: config.testEnvironmentOptions.userAgent,
})
: undefined,
runScripts: 'dangerously',
url: config.testURL,
virtualConsole: new VirtualConsole().sendTo(options?.console || console),
...config.testEnvironmentOptions,
});
this.dom = new JSDOM(
typeof config.testEnvironmentOptions.html === 'string'
? config.testEnvironmentOptions.html
: '<!DOCTYPE html>',
{
pretendToBeVisual: true,
resources:
typeof config.testEnvironmentOptions.userAgent === 'string'
? new ResourceLoader({
userAgent: config.testEnvironmentOptions.userAgent,
})
: undefined,
runScripts: 'dangerously',
url: config.testURL,
virtualConsole: new VirtualConsole().sendTo(
options?.console || console,
),
...config.testEnvironmentOptions,
},
);
const global = (this.global = this.dom.window.document
.defaultView as unknown as Win);

Expand Down