Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create new @jest/expect package #12404

Merged
merged 21 commits into from Feb 16, 2022
Merged

feat: create new @jest/expect package #12404

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6ccd1dc
introduce @jest/expect
mrazauskas Feb 16, 2022
7b2bea6
fix lock
mrazauskas Feb 16, 2022
e7ca2a2
fix lint
mrazauskas Feb 16, 2022
c22b839
clean up
mrazauskas Feb 16, 2022
d033c5e
remove expect dependency from circus
mrazauskas Feb 16, 2022
969d35e
refactor jasmine
mrazauskas Feb 16, 2022
f22b639
fix lint
mrazauskas Feb 16, 2022
1e230f0
move SnapshotMatchers
mrazauskas Feb 16, 2022
c2f0a81
tweak types
mrazauskas Feb 16, 2022
5b35ee6
Merge branch 'main' into feat-jest-expect
mrazauskas Feb 16, 2022
4dc3760
add minimal readme
mrazauskas Feb 16, 2022
0352b7f
add changelog entry
mrazauskas Feb 16, 2022
102031b
eslint comment
mrazauskas Feb 16, 2022
b9a27c2
tweak readme
mrazauskas Feb 16, 2022
de38ed2
clean up
mrazauskas Feb 16, 2022
e582a9a
bring back jest-snapshot
mrazauskas Feb 16, 2022
fa3e1c6
ensure snapshot matchers are gone from base expect, but present in jest
SimenB Feb 16, 2022
f1078f1
assignability
SimenB Feb 16, 2022
c7fa36c
addSnapshotSerializer test
mrazauskas Feb 16, 2022
f282d50
fix lost addSnapshotSerializer type
mrazauskas Feb 16, 2022
5262e2a
Update packages/jest-expect/src/types.ts
SimenB Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/jest-expect/__typetests__/jest-expect.test.ts
View file
Open in desktop
Expand Up @@ -13,14 +13,15 @@ import {
} from 'tsd-lite';
import {jestExpect} from '@jest/expect';
import {expect} from 'expect';
import type {Plugin} from 'pretty-format';

expectType<void>(jestExpect({}).toMatchSnapshot());

expectError(() => {
expect({}).toMatchSnapshot();
});

expectType<void>(jestExpect.addSnapshotSerializer({} as any));
expectType<void>(jestExpect.addSnapshotSerializer({} as Plugin));

expectError(() => {
expect.addSnapshotSerializer();
Expand Down
1 change: 1 addition & 0 deletions packages/jest-expect/src/types.ts
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ export type JestExpect = {
<T = unknown>(actual: T): JestMatchers<void, T> &
Inverse<JestMatchers<void, T>> &
PromiseMatchers<T>;
addSnapshotSerializer: typeof addSerializer;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds duplication, but it helps to work around the problem. Type is aded here to be visible for the user, but also left in augmentation to avoid casting in code. I will follow the issue in api-extractor and will clean up after it will be solved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment above it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above this line, that is

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(done)

SimenB marked this conversation as resolved.
Show resolved Hide resolved
} & BaseExpect &
AsymmetricMatchers &
Inverse<Omit<AsymmetricMatchers, 'any' | 'anything'>>;
Expand Down