Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Jest to run tests in node_modules #12438

Closed

Conversation

pauldraper
Copy link

Resolves #2145 and #11781. Prevent haste map from automatically discarding
node_modules files.

By default, node_modules is still excluded via the testPathIgnorePatterns
option. However, users can now use that option to allow node_modules
without hacks.

@facebook-github-bot
Copy link
Contributor

Hi @pauldraper!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Resolves jestjs#2145 and jestjs#11781. Prevent haste map from automatically discarding
node_modules files.

By default, node_modules is still excluded via the testPathIgnorePatterns
option. However, users can now use that option to allow node_modules
without hacks.
@mrazauskas
Copy link
Contributor

Similar open PRs #11084, #12280

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@pauldraper
Copy link
Author

pauldraper commented Feb 21, 2022

Similar open PRs #11084, #12280

Indeed. Perhaps this one will get a code review :/

(Though I do prefer retainAllFiles: true rather than adding a config option that competes with the existing testPathIgnorePatterns, any of these PRs would be a welcome fix for a bug report 5+ years ago.)

@SimenB
Copy link
Member

SimenB commented Feb 21, 2022

I think #11084 is better since it uses less memory by default, and wanting to run tests in node_modules is an edge case.

Thanks for sending a PR, though!

@SimenB SimenB closed this Feb 21, 2022
@pauldraper
Copy link
Author

pauldraper commented Feb 21, 2022

Okay, thanks.

But $15 says that PR still isn't merged 30 days from now.

@SimenB
Copy link
Member

SimenB commented Feb 21, 2022

You can help it get merged quicker by writing a test for it if you want 🙂

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest not running tests in src/node_modules
4 participants