Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(jest-mock)!: simplify usage of
jest.fn
generic type arguments #12489refactor(jest-mock)!: simplify usage of
jest.fn
generic type arguments #12489Changes from 1 commit
1132c7b
7df0d63
a08489e
561b907
4dce116
3f7fa09
bba8fdf
ab690af
2b1f2ab
b649fd2
c24d45d
b65d40a
d325678
d2e72f2
10f5596
7e9c4a2
7c61681
feb5722
6b0a31d
2cfbb5f
f7312dd
f5c620d
4ec19fe
4171124
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I double checked if the example works. All is correct. Will add it to
examples
folder later. TypeScript example will need more changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert back to draft so I don't accidentally merge? 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove this as well? comes from
@types/jest
and not usThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I took it out and will bring it back after
jest.Mocked
refactor. What about that note onCreate React App
? Just above?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, kill it. only thing under the
TypeScript
heading should be either pointing to "getting started" or examples usingjest
from@jest/globals
. All the other stuff (CRA, "see this repo", "jest is written in TS") should go, IMO