refactor(@jest/fake-timers): improve internal typings of legacy fake timers #12567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Mar 11, 2022
Comment on lines
-53
to
-56
| interface FakeTimersGlobal extends GlobalThis { | ||
| cancelAnimationFrame: (handle: number) => void; | ||
| requestAnimationFrame: (callback: (time: number) => void) => number; | ||
| } |
There was a problem hiding this comment.
Might be these types were copied from TS, because they do not exist on global in Node. globalThis defines these props, so now this is safe to remove, right?
mrazauskas
commented
Mar 11, 2022
| } | ||
|
|
||
| export default class FakeTimers<TimerRef> { | ||
| export default class FakeTimers<TimerRef = unknown> { |
There was a problem hiding this comment.
Adding a default to generic helps to keep FakeTimerAPI simple and slim.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #12489 I have noticed few TODO comments in legacy fake timers module. Indeed it was tricky to type mocked functions before #12489, but now this is rather simple thing.
Test plan
Green CI.