Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce same version of a dependency #12668

Merged
merged 36 commits into from
Apr 19, 2022
Merged

Enforce same version of a dependency #12668

merged 36 commits into from
Apr 19, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Apr 12, 2022 •
edited

Summary

Test plan

green ci

@F3n67u F3n67u changed the title enforce same version of a dependency Enforce same version of a dependency Apr 13, 2022
@F3n67u F3n67u marked this pull request as ready for review April 13, 2022 14:48
@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 13, 2022

@mrazauskas one version check is ready!

@F3n67u F3n67u force-pushed the same-version-constriant branch 3 times, most recently from be2e16e to a1efce1 Compare April 13, 2022 15:39
mrazauskas
mrazauskas reviewed Apr 13, 2022
View reviewed changes
e2e/coverage-remapping/package.json Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
F3n67u
F3n67u commented Apr 13, 2022
View reviewed changes
packages/jest-console/package.json
@@ -25,8 +25,7 @@
"slash": "^3.0.0"
},
"devDependencies": {
"@jest/test-utils": "^28.0.0-alpha.8",
"@types/node": "*"
"@jest/test-utils": "^28.0.0-alpha.8"
Copy link
Contributor Author

@F3n67u F3n67u Apr 13, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use workspace:* to reference the package in jest monorepo consistently instead of using the real version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, however lerna doesn't understand it: lerna/lerna#2564

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarnpkg/berry and babel both use workspace: schema to specify internal deps via yarn without lerna, maybe we could achieve that without lerna?

now we only use lerna to publish packages, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only used to publish, yes

@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 18, 2022

@SimenB this pr is ready. could you take a look?

SimenB
SimenB reviewed Apr 18, 2022
View reviewed changes
examples/snapshot/package.json Outdated Show resolved Hide resolved
packages/jest-console/package.json
@@ -25,8 +25,7 @@
"slash": "^3.0.0"
},
"devDependencies": {
"@jest/test-utils": "^28.0.0-alpha.8",
"@types/node": "*"
"@jest/test-utils": "^28.0.0-alpha.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, however lerna doesn't understand it: lerna/lerna#2564

F3n67u
F3n67u commented Apr 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
SimenB
SimenB reviewed Apr 19, 2022
View reviewed changes
yarn.lock Outdated
@@ -2651,7 +2663,21 @@ __metadata:
languageName: unknown
linkType: soft

"@jest/globals@^28.0.0-alpha.8, @jest/globals@workspace:*, @jest/globals@workspace:packages/jest-globals":
"@jest/fake-timers@npm:^27.5.1":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're now pulling in more 27 stuff, can these remain workspace:*?

Copy link
Member

@SimenB SimenB Apr 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably from the one example using workspace:*...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

SimenB
SimenB reviewed Apr 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
SimenB
SimenB reviewed Apr 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
SimenB
SimenB approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, thanks!

@SimenB SimenB merged commit ccecdae into jestjs:main Apr 19, 2022
@F3n67u F3n67u deleted the same-version-constriant branch April 19, 2022 10:53
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrazauskas mrazauskas mrazauskas left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@F3n67u @SimenB @mrazauskas @facebook-github-bot