Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native esm for babel config and babel custom plugin #12684

Closed
wants to merge 13 commits into from
Closed

Use native esm for babel config and babel custom plugin #12684

wants to merge 13 commits into from

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Apr 17, 2022

Summary

Test plan

@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 17, 2022

Current the ci fail reason is:

example/mongodb load babel config from the root babel.config.mjs instead of example/mongodb/jest.config.js, have not figure out how to make it load example/mongodb/jest.config.js

@SimenB
Copy link
Member

SimenB commented Apr 19, 2022

sounds like #12639 (comment)

@SimenB
Copy link
Member

SimenB commented Apr 19, 2022

And #12689 might fix it 🙂

SimenB
SimenB reviewed Apr 19, 2022
View reviewed changes
babel.config.mjs Outdated Show resolved Hide resolved
@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 19, 2022

And #12689 might fix it 🙂

great. I already merged your work into this branch.

@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Aug 19, 2022
@SimenB
Copy link
Member

SimenB commented Aug 19, 2022

What's the state here? Logs have been deleted 😅

@github-actions github-actions bot removed the Stale label Aug 19, 2022
@F3n67u
Copy link
Contributor Author

F3n67u commented Aug 20, 2022

What's the state here? Logs have been deleted 😅

I think this pr is indeed stale. let us close it.

@F3n67u F3n67u closed this Aug 20, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
@F3n67u F3n67u deleted the babel-esm branch September 20, 2022 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB left review comments

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@F3n67u @SimenB @facebook-github-bot