fix: issue with trailing slash in matching coverageThreshold keys

CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Fixes
 
 - `[*]` Lower Node 16 requirement to 16.10 from 16.13 due to a [Node bug](https://github.com/nodejs/node/issues/40014) that causes memory and performance issues ([#12754](https://github.com/facebook/jest/pull/12754))
+- `[@jest/reporters]` Fix trailing slash in matching `coverageThreshold` key ([#12714](https://github.com/facebook/jest/pull/12714))
 
 ### Chore & Maintenance
 
@@ -45,7 +46,7 @@
 - `[jest-config]` [**BREAKING**] Rename `moduleLoader` to `runtime` ([#10817](https://github.com/facebook/jest/pull/10817))
 - `[jest-config]` [**BREAKING**] Rename `extraGlobals` to `sandboxInjectedGlobals` ([#10817](https://github.com/facebook/jest/pull/10817))
 - `[jest-config]` [**BREAKING**] Throw an error instead of showing a warning if multiple configs are used ([#12510](https://github.com/facebook/jest/pull/12510))
-- `[jest-config]` [**BREAKING**] Do not normalize long deprecated configuration options `preprocessorIgnorePatterns`,`scriptPreprocessor`, `setupTestFrameworkScriptFile` and `testPathDirs` ([#1251270110](https://github.com/facebook/jest/pull/12701))
+- `[jest-config]` [**BREAKING**] Do not normalize long deprecated configuration options `preprocessorIgnorePatterns`, `scriptPreprocessor`, `setupTestFrameworkScriptFile` and `testPathDirs` ([#12701](https://github.com/facebook/jest/pull/12701))
 - `[jest-cli, jest-core]` Add `--ignoreProjects` CLI argument to ignore test suites by project name ([#12620](https://github.com/facebook/jest/pull/12620))
 - `[jest-core]` Pass project config to `globalSetup`/`globalTeardown` function as second argument ([#12440](https://github.com/facebook/jest/pull/12440))
 - `[jest-core]` Stabilize test runners with event emitters ([#12641](https://github.com/facebook/jest/pull/12641))

packages/jest-reporters/src/CoverageReporter.ts

@@ -273,7 +273,16 @@ export default class CoverageReporter extends BaseReporter {
         const pathOrGlobMatches = thresholdGroups.reduce<
           Array<[string, string]>
         >((agg, thresholdGroup) => {
-          const absoluteThresholdGroup = path.resolve(thresholdGroup);
+          // Preserve trailing slash, but not required if root dir
+          // See https://github.com/facebook/jest/issues/12703
+          const resolvedThresholdGroup = path.resolve(thresholdGroup);
+          const suffix =
+            (thresholdGroup.endsWith(path.sep) ||
+              (process.platform === 'win32' && thresholdGroup.endsWith('/'))) &&
+            !resolvedThresholdGroup.endsWith(path.sep)
+              ? path.sep
+              : '';
+          const absoluteThresholdGroup = `${resolvedThresholdGroup}${suffix}`;
 
           // The threshold group might be a path:
 

packages/jest-reporters/src/__tests__/CoverageReporter.test.js

@@ -44,7 +44,9 @@ beforeEach(() => {
     'non_covered_file.js': '',
     'relative_path_file.js': '',
   };
-
+  fileTree[`${process.cwd()}/path-test`] = {
+    '100pc_coverage_file.js': '',
+  };
   mock(fileTree);
 });
 
@@ -79,6 +81,10 @@ describe('onRunComplete', () => {
         statements: {covered: 5, pct: 50, skipped: 0, total: 10},
       };
       const fileCoverage = [
+        [
+          './path-test/100pc_coverage_file.js',
+          {statements: {covered: 10, pct: 100, total: 10}},
+        ],
         ['./path-test-files/covered_file_without_threshold.js'],
         ['./path-test-files/full_path_file.js'],
         ['./path-test-files/relative_path_file.js'],
@@ -309,6 +315,9 @@ describe('onRunComplete', () => {
           './path-test-files/': {
             statements: 50,
           },
+          './path-test/': {
+            statements: 100,
+          },
           global: {
             statements: 100,
           },
@@ -370,6 +379,9 @@ describe('onRunComplete', () => {
           './path-test-files/100pc_coverage_file.js': {
             statements: 100,
           },
+          './path-test/100pc_coverage_file.js': {
+            statements: 100,
+          },
           global: {
             statements: 50,
           },