chore: remove unused jest-environment-jsdom mock
#13132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Aug 14, 2022
| console: {}, | ||
| }; | ||
|
|
||
| const globalValues = {...config.globals}; |
There was a problem hiding this comment.
To work this should be ...projectConfig.globals
| } | ||
| }); | ||
|
|
||
| JSDOMEnvironment.prototype.runSourceText.mockImplementation(function ( |
There was a problem hiding this comment.
Seems like runSourceText is not a member of JSDOMEnvironment for some time. TS gives an error here, but there is no way to fix it
mrazauskas
changed the title
jest-environment-jsdom mockjest-environment-jsdom mock
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #12856, I have noticed a manual mock in
jest-environment-jsdompackage. It had few type errors. I was trying to fix those, but it seems like this mock is unused. The API inside the mock are outdated and if the file is removed tests are passing locally. Just wondering what CI thinks?Test plan
Green CI.