fix(tests): clean up jest.Mock usage in tests
#13238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Sep 10, 2022
| @@ -652,7 +658,7 @@ const createSpy = (fn: jest.Mock) => { | |||
|
|
|||
| test('incomplete recursive calls are handled properly', () => { | |||
| // sums up all integers from 0 -> value, using recursion | |||
| const fn: jest.Mock = jest.fn(value => { | |||
| const fn: jest.Mock<number, [value: number]> = jest.fn(value => { | |||
There was a problem hiding this comment.
Otherwise the default is jest.Mock<any, any>.
Comment on lines
-21
to
-23
| const cases: Record<string, jest.Mock> = { | ||
| fancyCondition: jest.fn(path => path.length > 10), | ||
| testRegex: jest.fn(path => /.test.js$/.test(path)), |
There was a problem hiding this comment.
jest.fn() does nothing here. Can be simplified.
Comment on lines
+27
to
+30
| afterEach(() => { | ||
| jest.clearAllMocks(); | ||
| jest.resetModules(); | ||
| }); |
There was a problem hiding this comment.
Tricky one. If I got it right: fake was being reset manually, looks like jest.clearAllMocks() does the same job; also require in beforeEach above has no effect without jest.resetModules() because of module caching. Or?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #13235
Summary
Cleaning up
jest.Mockusage in tests. The type was unnecessary or used to manually reset a mock function (jest.clearAllMocks()seemed like better idea). Otherwise I used generic type arguments to have it typed it properly. Also fixed other type errors in these tests and a couple of typos caught by cspell.This should help migrating to build-in Jest types and to setup typecheck for test files one day.
Test plan
Green CI.