Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc:-Improve doc for expect not,array|object containing() actual behaviour #13351

Closed
wants to merge 1 commit into from
Closed

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Oct 1, 2022

Tried to improve the docs for the arrayContaining, ObjectContaining and ObjectnotContaining, Also added tests for the assymetric matchers.

@Biki-das Biki-das changed the title Doc:-Improve doc for expect not,array|object containing() actual behaviour doc:-Improve doc for expect not,array|object containing() actual behaviour Oct 1, 2022
@mrazauskas
Copy link
Contributor

Duplicate of #11157

@Biki-das
Copy link
Contributor Author

Biki-das commented Oct 1, 2022

Duplicate of #11157

I find this can. Go now! :+), as we have reached jest 28+

@Smrtnyk
Copy link

Smrtnyk commented Oct 1, 2022

Duplicate of #11157

I find this can. Go now! :+), as we have reached jest 28+

I honestly don't find it fair using other peoples commits, not even referencing them in your PRs
not a good OSS contribution approach

@Biki-das
Copy link
Contributor Author

Biki-das commented Oct 1, 2022

Oops 😅🤦‍♂

@Biki-das Biki-das closed this Oct 1, 2022
@mrazauskas
Copy link
Contributor

I honestly don't find it fair using other peoples commits, not even referencing them in your PRs not a good OSS contribution approach

@Smrtnyk Thanks for saying this loud.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants