chore: add typecheck for expect tests
#13383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Oct 4, 2022
mrazauskas
commented
Oct 4, 2022
mrazauskas
commented
Oct 4, 2022
| @@ -69,6 +64,17 @@ declare module '../types' { | |||
| } | |||
| } | |||
|
|
|||
| const jestExpect = importedExpect as typeof importedExpect & { | |||
There was a problem hiding this comment.
In this case typings have to be added like this. TypeScript is not happy about merging declaration of AsymmetricMatchers interface – it goes looking for expect object in ../index.ts, does not find properties from the declaration and complains.
|
Typecheck passed. Yes! That was quite some job. But in the end I am very happy about those tiny changes and improvement which were brought to Jest types. |
SimenB
approved these changes
Oct 4, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test of
expectpackage got reworked and clean up. Almost ready to be typechecked. I have to deal with a couple of details (see comments).Test plan
Green CI.