Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mocking of getters/setters on automatically mocked classes #13460

Closed
wants to merge 19 commits into from
Closed

fix: mocking of getters/setters on automatically mocked classes #13460

wants to merge 19 commits into from

Commits on Oct 6, 2022

  1. Revert "Revert "fix: mocking of getters/setters on automatically mock… 

    …ed classes (jestjs#13145)""

This reverts commit 52d45be.

# Conflicts:
#	CHANGELOG.md
    @staplespeter
    staplespeter committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    8d31725 View commit details
    Browse the repository at this point in the history

  2. bug 13140 - Added condition to prevent refs to auto-mocked superclass… 

    … 'get'/'set' functions being mocked as accessor objects. Added extra tests for this, and for some other conditions. Corrected expected test error messages due to the refactored code for the fix to this bug.
    @staplespeter
    staplespeter committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    46c92d6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into bug-13140

    @staplespeter
    staplespeter committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    571ad48 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. bug 13140 - Lint changes

    @staplespeter
    staplespeter committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d315f78 View commit details
    Browse the repository at this point in the history

  2. bug 13140 - requested repo reorg

    @staplespeter
    staplespeter committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    6c3af0d View commit details
    Browse the repository at this point in the history

  3. Update jest.config.mjs 

    Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
    @staplespeter @mrazauskas
    staplespeter and mrazauskas committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c36a196 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @SimenB
    SimenB committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    e7e4242 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into bug-13140

    @SimenB
    SimenB committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    9be113c View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Merge branch 'main' into bug-13140 

    # Conflicts:
#	CHANGELOG.md
    @staplespeter
    staplespeter committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    2d2648d View commit details
    Browse the repository at this point in the history

  2. bug-13140 - added tests for function exports mocked using spyOn. Thes… 

    …e currently only test for functions exported as data properties, not as accessors/getters
    @staplespeter
    staplespeter committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    e7f1a1c View commit details
    Browse the repository at this point in the history

  3. bug-13140 - reinstating spyOn functionality that allowed mocking of f… 

    …unctions exported as accessors/getters
    @staplespeter
    staplespeter committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    d9efe2d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. bug-13140: Added restoring of accessor properties. Updated tests for … 

    …restoring of accessor properties. Test for function exports via getters.
    @staplespeter
    staplespeter committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    f329d8a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into bug-13140

    @staplespeter
    staplespeter committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    fa0843d View commit details
    Browse the repository at this point in the history

  3. bug-13140: falling back to user of hasOwnProperty() in tests

    @staplespeter
    staplespeter committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    bd5ab67 View commit details
    Browse the repository at this point in the history

  4. bug-13140: applying lint check exception per line

    @staplespeter
    staplespeter committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    80375e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Merge branch 'main' into bug-13140

    @SimenB
    SimenB committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    8907420 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'facebook:main' into bug-13140

    @staplespeter
    staplespeter committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    da76c29 View commit details
    Browse the repository at this point in the history

  3. bug-13140: reverting spyOn methods to the original format.

    @staplespeter
    staplespeter committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    2facdf1 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. bug-13140: reinstating change removed from last merge frommain

    @staplespeter
    staplespeter committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ee0013a View commit details
    Browse the repository at this point in the history