Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended async-await in examples #14039

Closed
wants to merge 1 commit into from
Closed

Conversation

piranna
Copy link
Contributor

@piranna piranna commented Mar 30, 2023

Summary

Test plan

@mrazauskas
Copy link
Contributor

mrazauskas commented Mar 30, 2023

Take a look here:

https://github.com/facebook/jest/blob/c97467c88a313054c2dbe189db8fff3cce9122f9/website/versioned_docs/version-29.5/TestingAsyncCode.md?plain=1#L42-L52

And check #12555 as well.

Seems like the order of sections got messed up in the mention PR. Would be good to fix that.

EDIT: I mean, ".resolves / .rejects" section should be simply moved after "Promises" section where it was before.

@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jun 28, 2023
@piranna
Copy link
Contributor Author

piranna commented Jun 28, 2023

Can we get this merged? What's missing?

@mrazauskas
Copy link
Contributor

Looks like you missed my comment above. Or? (;

@github-actions github-actions bot removed the Stale label Jun 28, 2023
@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 26, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this Oct 26, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants