fix: Replace broken goo.gl link with actual docs link

[legobeat]

Summary

• Unobfuscate destination URL
• Remove need for user to access Google services to discover relevant docs
• Future-proof - no risk of sunsetting or unavailability of intermediary service causing breakage

Test plan

[facebook-github-bot]

Hi @legobeat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[SimenB]

this is a breaking change, so cannot be done until the next major.

the URL also seems broken - it's supposed to point to https://jestjs.io/docs/snapshot-testing

[SimenB]

/easycla

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: legobeat (0036432, 074f02b, cc84ce1, d57aeec, 864f06e)

[legobeat]

@SimenB How would this be breaking? Fixed the broken link.

[netlify]

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	864f06e
🔍 Latest deploy log	https://app.netlify.com/sites/jestjs/deploys/66263177f2610f0008b9b015
😎 Deploy Preview	https://deploy-preview-14081--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mrazauskas]

How would this be breaking? Fixed the broken link.

Only in this PR almost 150 snapshots are not passing. Now imagine Renovate bot upgrading Jest: all snapshot users will get red CIs (because snapshots are not updated in CI). This simply should not happen between minor releases.

[mrazauskas]

By the way, you should include change log entry too.

[legobeat]

If CI indeed breaks, it would be very helpful if the workflow could be approved.

[legobeat]

By the way, you should include change log entry too.

Where should a log be added, apart from bddff35?

[mrazauskas]

If CI indeed breaks, it would be very helpful if the workflow could be approved.

Do you speak about the CI in this repo? This will pass. I had in mind the CIs which run Jest for users in repos which are being updated by bots like Renovate.

[legobeat]

Hm, wouldn't the same hold f.e. for these, which were treated as non-breaking?

f2f578f (#12303)
d106643 (#14073)
e3d5491 (#10982)

[mrazauskas]

These two are changing something in this repo only (because lock file or snapshots are not shipped to NPM). The change you are making will be shipped to the users.

In other other words, the changes you are referring have zero impact on code of jest which people install from NPM, but your change will impact everyone.

[mrazauskas]

Looks good for my eye. Thanks!

[legobeat]

Fixed changelog conflict.

[SimenB]

thanks!

You don't have to keep this conflict free btw - I'll deal with it when I start landing breaking changes for v30 🙂