Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel option rename (blacklist -> denylist) #14109

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

nicolo-ribaudo
Copy link
Contributor

Summary

Babel currently has two names for the same option (blacklist and denylist); we are going to remove on in Babel 8. This should fix the Babel 8 error in babel/babel#15576.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f6b2f5
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/650a981d1501890008539131
😎 Deploy Preview https://deploy-preview-14109--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Apr 25, 2023

Does this mean we need to adjust some peer deps for older versions of v7?


DefinitelyTyped/DefinitelyTyped#49229

😀

@nicolo-ribaudo
Copy link
Contributor Author

Oh right :) It has been released in v7.11.0, while Jest has a peerDependency on 7.0.0 (

"@babel/core": "^7.0.0"
) and one on 7.8.0 (
"@babel/core": "^7.8.0"
).

There is no rush for this PR, we can wait until Jest 30 is ready (or even later!).

@SimenB
Copy link
Member

SimenB commented Apr 25, 2023

Let's land it for 30 👍

@SimenB SimenB added this to the Jest 30 milestone Apr 25, 2023
@SimenB SimenB added the Pinned label Apr 25, 2023
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB enabled auto-merge (squash) September 20, 2023 06:59
@SimenB SimenB merged commit 0081f94 into jestjs:main Sep 20, 2023
62 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the patch-1 branch September 20, 2023 15:32
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
@SimenB
Copy link
Member

SimenB commented Oct 30, 2023

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants