Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability of regular expression denial of service by upgrading semver to 7.5.3 #14262

Conversation

ziyad-elabid-nw
Copy link
Contributor

@ziyad-elabid-nw ziyad-elabid-nw commented Jun 25, 2023

Summary

At the moment, Jest uses version 7.3.5 of semver. The problem arises when launching the command 'yarn audit' due to a vulnerability in regular expression denial of service via the function 'new Range'. You can find more information about this vulnerability in the following reference: GHSA-c2qf-rxjj-qqgw

This pull request (PR) proposes upgrading the semver dependency to version 7.5.3 because it includes the necessary patches for versions greater than or equal to 7.5.2.

Test plan

Green CI

Thanks !

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 25, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Jun 25, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1d90919
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6499773d1848b40007dac4e2
😎 Deploy Preview https://deploy-preview-14262--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ziyad-elabid-nw ziyad-elabid-nw force-pushed the fix-vulnerability-by-upgrading-semver-version branch from 66eb393 to 416c59a Compare June 25, 2023 01:41
@hildjj
Copy link

hildjj commented Jun 25, 2023

This probably needs to be semver 7.5.3 at this point.

@ziyad-elabid-nw
Copy link
Contributor Author

@hildjj version 7.5.2 or any higher version would be suitable for addressing this problem, as it contains the necessary patches.

@Fdawgs
Copy link
Contributor

Fdawgs commented Jun 26, 2023

@hildjj version 7.5.2 or any higher version would be suitable for addressing this problem, as it contains the necessary patches.

Probably still worth doing for posterity's sake, no?

@SimenB
Copy link
Member

SimenB commented Jun 26, 2023

Fixed version is in semver range, so we don't have to update here. Happy do so if it helps, though 👍

Can you update to 7.5.3 and add a changelog entry?

@ziyad-elabid-nw
Copy link
Contributor Author

Fixed version is in semver range, so we don't have to update here. Happy do so if it helps, though 👍

Can you update to 7.5.3 and add a changelog entry?

Done 👍

@ziyad-elabid-nw ziyad-elabid-nw changed the title Fix vulnerability of regular expression denial of service by upgrading semver to 7.5.2 Fix vulnerability of regular expression denial of service by upgrading semver to 7.5.3 Jun 26, 2023
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 3da370f into jestjs:main Jun 26, 2023
5 checks passed
@SimenB
Copy link
Member

SimenB commented Jul 4, 2023

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants