Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks Reporter's hooks as optional #14433

Merged
merged 4 commits into from Aug 21, 2023
Merged

Conversation

panteleevnikita
Copy link
Contributor

onRunStart and getLastError should be optional, fixes #14427

Summary

Test plan

onRunStart and getLastError should be optional
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 20, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d2ddc68
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64e353265299a000083fccc4
😎 Deploy Preview https://deploy-preview-14433--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@panteleevnikita panteleevnikita marked this pull request as ready for review August 20, 2023 17:22
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Reporter interface typing is too strong?
2 participants