fix(jest-core): Correct typo in performance.mark() label for scheduleAndRun:end
#14434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
No rush to release this btw - I've worked around it in our Jest wrapper for now, this would just be useful to tidy up the next time we get around to a Jest bump. |
Oh wow, awesome! |
This was referenced Aug 28, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes my typo from #13859 - I'd accidentally marked
jest/scheduleAndRun:startboth before and afterawait scheduleTests().Test plan
Since upgrading to Jest 29.6.3 we now have instrumentation running for Jest at Meta and will be able to measure any startup improvements or regressions - happy to share aggregate data :). Thanks @SimenB in particular for your support on this.
(Ok, that wasn't really a test plan. 👀 for this one, I guess.)