Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with inline snapshots when snapshot is string not template literal #14465

Merged
merged 2 commits into from Sep 5, 2023

Conversation

bawjensen
Copy link
Contributor

Summary

Fixes #14464.

Please let me know what else I can do to flesh this PR out. I could quite well be overlooking something.

Test plan

Added a unit test.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c9d2a5f
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64f11609628b3a0008c19dee
😎 Deploy Preview https://deploy-preview-14465--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

@SimenB SimenB merged commit 5611a1d into jestjs:main Sep 5, 2023
91 checks passed
@SimenB
Copy link
Member

SimenB commented Sep 12, 2023

https://github.com/jestjs/jest/releases/tag/v29.7.0

@bawjensen bawjensen deleted the inline-snapshot-template-literal-fix branch September 12, 2023 18:46
@bryan-codaio
Copy link

tyvm for the quick turnaround and the notification that it's been released

@SimenB
Copy link
Member

SimenB commented Sep 12, 2023

All credits to @bawjensen for this, but happy to hear it helped you! 😀 most feedback I get are people complaining, so happy to see some people appreciate the work we all do 👍👍

@bawjensen
Copy link
Contributor Author

ah @bryan-codaio is me posting from the wrong account 😅

I can relate to appreciating the positive feedback to offset the negative - most folks don't remember to mention the good moments (I almost forgot to follow up here after bumping the dependency version to 29.7.0), so I try to make a point of it

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inline snapshots are appending a new template literal instead of replacing existing string
3 participants