chore: produce sourcemaps when building Jest #14591
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@liuxingbaoyu does something like this work for you? Before I spend more time on removing the extra frames in stacks 😅 |
SimenB
commented
Oct 2, 2023
| @@ -273,11 +275,21 @@ export function createBuildConfigs() { | |||
| moduleIds: 'named', | |||
| }, | |||
| output: { | |||
| devtoolModuleFilenameTemplate(info) { | |||
There was a problem hiding this comment.
this is to get relative paths in the sourcemaps instead of the absolute path from the machine of the person running the build
|
Amazing! It's working now, a few places where I can't set breakpoints than before, but not important. |
|
Cool, thanks for confirming 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will make debugging Jest itself easier. Not sure if we should include them in the tarball when publishing, but possibly? Then we could probably also minify the code
Test plan
Green CI (eventually)