New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serve a JSON schema from website #14792
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for jestjs failed.
|
@@ -226,129 +226,145 @@ const RawHasteConfig = Type.Partial( | |||
); | |||
|
|||
export const RawInitialOptions = Type.Partial( | |||
Type.Object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore whitespace (https://github.com/jestjs/jest/pull/14792/files?w=1) - I just added some meta properties at the end
@@ -51,6 +52,7 @@ | |||
"@crowdin/cli": "^3.5.2", | |||
"@docusaurus/module-type-aliases": "^3.0.0", | |||
"@docusaurus/tsconfig": "^3.0.0", | |||
"@jest/schemas": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add "@jest/schemas-30x": "npm:@jest/schemas@^30"
etc later for different versions
I'm not allowed to see the logs of the (currently failing) deployment 🙈 |
Perhaps it would make sense to add schema URI to documentation? I mean, simply to use it in the JSON config example: {
"$schema": "https://jestjs.io/schema.json"
"bail": 1,
"verbose": true
} |
Just to add, some time ago I was playing with |
I think I added a self link in https://github.com/jestjs/jest/pull/14792/files#diff-cf140d6648a6d236a6a5ce32888aa504827a65dd89139174ec30e7da8db128a4R23 |
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Summary
I have zero clue if this is gonna work or not 😅 If it does work though, this closes #11963
Test plan
Verify deployment preview